stawros/konta-walutowe
1
0
Fork 0
Code Issues Pull requests Releases Packages Activity

Compare commits

base: stawros:ca2a6c179562583f8510227dcef7b280ec8ebb36
Branches Tags
stawros:master
stawros:rest-api
stawros:rest-controllers
stawros:currency-service
stawros:user-service
stawros:v/1.1.0
stawros:v/1.0.0
..
compare: stawros:7e38b5a2e0416831cfe1657e379b03fde3709abc
Branches Tags
stawros:master
stawros:rest-api
stawros:rest-controllers
stawros:currency-service
stawros:user-service
stawros:v/1.1.0
stawros:v/1.0.0

No commits in common. "ca2a6c179562583f8510227dcef7b280ec8ebb36" and "7e38b5a2e0416831cfe1657e379b03fde3709abc" have entirely different histories.
ca2a6c1795 ... 7e38b5a2e0

6 changed files with 24 additions and 150 deletions
Download patch file Download diff file Expand all files Collapse all files

24
src/main/java/eu/ztsh/wymiana/validation/ValidExchangeRequest.java
View file

@ -1,24 +0,0 @@
package eu.ztsh.wymiana.validation;
import jakarta.validation.Constraint;
import jakarta.validation.Payload;
import java.lang.annotation.Documented;
import java.lang.annotation.Retention;
import java.lang.annotation.Target;
import static java.lang.annotation.ElementType.TYPE_USE;
import static java.lang.annotation.RetentionPolicy.RUNTIME;
@Retention(RUNTIME)
@Target({ TYPE_USE })
@Documented
@Constraint(validatedBy = {ValidExchangeRequestValidator.class })
public @interface ValidExchangeRequest {
String message() default "Exchange request is not valid";
Class<?>[] groups() default { };
Class<? extends Payload>[] payload() default { };
}

15
src/main/java/eu/ztsh/wymiana/validation/ValidExchangeRequestValidator.java
View file

@ -1,15 +0,0 @@
package eu.ztsh.wymiana.validation;
import eu.ztsh.wymiana.web.model.CurrencyExchangeRequest;
import jakarta.validation.ConstraintValidator;
import jakarta.validation.ConstraintValidatorContext;
public class ValidExchangeRequestValidator implements ConstraintValidator<ValidExchangeRequest, CurrencyExchangeRequest> {
@Override
public boolean isValid(CurrencyExchangeRequest currencyExchangeRequest,
ConstraintValidatorContext constraintValidatorContext) {
return false;
}
}

18
src/main/java/eu/ztsh/wymiana/web/model/CurrencyExchangeRequest.java
View file

@ -1,18 +0,0 @@
package eu.ztsh.wymiana.web.model;
import eu.ztsh.wymiana.validation.ValidExchangeRequest;
import jakarta.validation.constraints.NotNull;
import lombok.Builder;
import org.hibernate.validator.constraints.pl.PESEL;
@Builder
@ValidExchangeRequest
public record CurrencyExchangeRequest(
@PESEL String pesel,
@NotNull String from,
@NotNull String to,
Double toBuy,
Double toSell
) {
}

32
src/test/java/eu/ztsh/wymiana/validation/AdultValidatorTest.java
View file

@ -1,42 +1,58 @@
package eu.ztsh.wymiana.validation;
import jakarta.validation.ConstraintValidatorContext;
import org.hibernate.validator.internal.engine.DefaultClockProvider;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.mockito.Mockito;
class AdultValidatorTest extends ValidatorTest<AdultValidator, String> {
import static org.assertj.core.api.Assertions.assertThat;
protected AdultValidatorTest() {
super(new AdultValidator());
class AdultValidatorTest {
private static AdultValidator validator;
private static ConstraintValidatorContext validatorContext;
@BeforeAll
static void prepare() {
validator = new AdultValidator();
validatorContext = Mockito.mock(ConstraintValidatorContext.class);
Mockito.when(validatorContext.getClockProvider()).thenReturn(DefaultClockProvider.INSTANCE);
}
@Test
@DisplayName("No digits in PESEL")
void invalidPatternTest() {
assertThatValidation("notAPesel").isFalse();
assertThat(call("notAPesel")).isFalse();
}
@Test
@DisplayName("Not an adult")
void notAnAdultTest() {
assertThatValidation("24242400000").isFalse();
assertThat(call("24242400000")).isFalse();
}
@Test
@DisplayName("Adult")
void adultTest() {
assertThatValidation("88010100000").isTrue();
assertThat(call("88010100000")).isTrue();
}
@Test
@DisplayName("Elderly person")
void seniorTest() {
assertThatValidation("00010100000").isTrue();
assertThat(call("00010100000")).isTrue();
}
@Test
@DisplayName("Invalid date")
void notAValidDateTest() {
assertThatValidation("00919100000").isFalse();
assertThat(call("00919100000")).isFalse();
}
private boolean call(String value) {
return validator.isValid(value, validatorContext);
}
}

54
src/test/java/eu/ztsh/wymiana/validation/ValidExchangeRequestValidatorTest.java
View file

@ -1,54 +0,0 @@
package eu.ztsh.wymiana.validation;
import eu.ztsh.wymiana.web.model.CurrencyExchangeRequest;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
class ValidExchangeRequestValidatorTest extends ValidatorTest<ValidExchangeRequestValidator, CurrencyExchangeRequest> {
protected ValidExchangeRequestValidatorTest() {
super(new ValidExchangeRequestValidator());
}
@Test
@DisplayName("Valid request with buy value specified")
void validRequestWithBuyTest() {
}
@Test
@DisplayName("Valid request with sell value specified")
void validRequestWithSellTest() {
}
@Test
@DisplayName("Invalid PESEL value")
void invalidPeselTest() {
}
@Test
@DisplayName("From and To have same value")
void sameFromToTest() {
}
@Test
@DisplayName("Empty amounts")
void emptyBuySellTest() {
}
@Test
@DisplayName("Both Buy and Sell params filled in")
void bothFilledBuySellTest() {
}
@Test
@DisplayName("Negative amount value")
void negativeAmountTest() {
}
}

31
src/test/java/eu/ztsh/wymiana/validation/ValidatorTest.java
View file

@ -1,31 +0,0 @@
package eu.ztsh.wymiana.validation;
import jakarta.validation.ConstraintValidator;
import jakarta.validation.ConstraintValidatorContext;
import org.assertj.core.api.AbstractBooleanAssert;
import org.hibernate.validator.internal.engine.DefaultClockProvider;
import org.junit.jupiter.api.BeforeAll;
import org.mockito.Mockito;
import static org.assertj.core.api.Assertions.assertThat;
public abstract class ValidatorTest<V extends ConstraintValidator<?, C>, C> {
private final V validator;
private static ConstraintValidatorContext validatorContext;
protected ValidatorTest(V validator) {
this.validator = validator;
}
@BeforeAll
static void prepare() {
validatorContext = Mockito.mock(ConstraintValidatorContext.class);
Mockito.when(validatorContext.getClockProvider()).thenReturn(DefaultClockProvider.INSTANCE);
}
protected AbstractBooleanAssert<?> assertThatValidation(C value) {
return assertThat(validator.isValid(value, validatorContext));
}
}