fix: Request validation in UserService
This commit is contained in:
parent
1eee6b1b48
commit
7e38b5a2e0
9 changed files with 126 additions and 26 deletions
|
@ -5,7 +5,11 @@ import eu.ztsh.wymiana.RepositoryBasedTest;
|
|||
import eu.ztsh.wymiana.data.repository.UserRepository;
|
||||
import eu.ztsh.wymiana.exception.UserAlreadyExistsException;
|
||||
import eu.ztsh.wymiana.util.UserMapper;
|
||||
import eu.ztsh.wymiana.validation.Adult;
|
||||
import eu.ztsh.wymiana.validation.InstanceValidator;
|
||||
import eu.ztsh.wymiana.validation.ValidationFailedException;
|
||||
import jakarta.transaction.Transactional;
|
||||
import org.junit.jupiter.api.DisplayName;
|
||||
import org.junit.jupiter.api.Test;
|
||||
import org.springframework.beans.factory.annotation.Autowired;
|
||||
|
||||
|
@ -17,44 +21,72 @@ class UserServiceTest extends RepositoryBasedTest {
|
|||
private final UserService userService;
|
||||
|
||||
@Autowired
|
||||
public UserServiceTest(UserRepository userRepository) {
|
||||
public UserServiceTest(UserRepository userRepository, InstanceValidator instanceValidator) {
|
||||
super(userRepository);
|
||||
userService = new UserService(userRepository);
|
||||
userService = new UserService(userRepository, instanceValidator);
|
||||
}
|
||||
|
||||
@Test
|
||||
@Transactional
|
||||
@DisplayName("Create new user")
|
||||
void createNewUserTest() {
|
||||
userService.create(EntityCreator.userRequest());
|
||||
userService.create(EntityCreator.userRequest().build());
|
||||
var entity = EntityCreator.user().build();
|
||||
expect(entity);
|
||||
}
|
||||
|
||||
@Test
|
||||
void createDuplicatedUser() {
|
||||
var first = EntityCreator.userRequest();
|
||||
var second = EntityCreator.userRequest();
|
||||
@DisplayName("Try to create user that already exists")
|
||||
void createDuplicatedUserTest() {
|
||||
var first = EntityCreator.userRequest().build();
|
||||
var second = EntityCreator.userRequest().build();
|
||||
userService.create(first);
|
||||
assertThatThrownBy(() -> userService.create(second))
|
||||
.isInstanceOf(UserAlreadyExistsException.class)
|
||||
.hasMessage("User with PESEL %s already exists".formatted(EntityCreator.Constants.PESEL));
|
||||
.isInstanceOf(UserAlreadyExistsException.class)
|
||||
.hasMessage("User with PESEL %s already exists".formatted(EntityCreator.Constants.PESEL));
|
||||
}
|
||||
|
||||
@Test
|
||||
@DisplayName("Try to create another user with same PESEL")
|
||||
void createDuplicatedPeselTest() {
|
||||
var first = EntityCreator.userRequest().build();
|
||||
var second = EntityCreator.userRequest()
|
||||
.name("Jan")
|
||||
.surname("Kowalski")
|
||||
.pln(30.30)
|
||||
.build();
|
||||
userService.create(first);
|
||||
assertThatThrownBy(() -> userService.create(second))
|
||||
.isInstanceOf(UserAlreadyExistsException.class)
|
||||
.hasMessage("User with PESEL %s already exists".formatted(EntityCreator.Constants.PESEL));
|
||||
}
|
||||
|
||||
@Test
|
||||
@DisplayName("Try to create too young user")
|
||||
void youngUserTest() {
|
||||
var request = EntityCreator.userRequest().pesel("08280959342").build();
|
||||
assertThatThrownBy(() -> userService.create(request))
|
||||
.isInstanceOf(ValidationFailedException.class)
|
||||
.hasMessageContaining(Adult.MESSAGE);
|
||||
}
|
||||
|
||||
@Test
|
||||
@Transactional
|
||||
@DisplayName("Get existing user")
|
||||
void getExistingUserTest() {
|
||||
var entity = EntityCreator.user().build();
|
||||
userRepository.save(entity);
|
||||
var userOptional = userService.get(EntityCreator.Constants.PESEL);
|
||||
var expected = UserMapper.entityToPojo(entity);
|
||||
assertThat(userOptional)
|
||||
.isNotEmpty()
|
||||
.get()
|
||||
.usingRecursiveComparison()
|
||||
.isEqualTo(expected);
|
||||
.isNotEmpty()
|
||||
.get()
|
||||
.usingRecursiveComparison()
|
||||
.isEqualTo(expected);
|
||||
}
|
||||
|
||||
@Test
|
||||
@DisplayName("Try get non-existing user")
|
||||
void getNonExistingUserTest() {
|
||||
var userOptional = userService.get(EntityCreator.Constants.PESEL);
|
||||
assertThat(userOptional).isEmpty();
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue