stawros/konta-walutowe
1
0
Fork 0
Code Issues Pull requests Releases Packages Activity

test: SonarLint fixes

Browse source
This commit is contained in:
Piotr Dec 2024-05-24 08:33:57 +02:00
parent af187e3daa
commit 6d8a2093b9
Signed by: stawros
GPG key ID: F89F27AD8F881A91
2 changed files with 16 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

21
src/test/java/eu/ztsh/wymiana/service/CurrencyServiceTest.java
View file

@ -6,7 +6,6 @@ import eu.ztsh.wymiana.data.repository.UserRepository;
import eu.ztsh.wymiana.exception.InsufficientFundsException; import eu.ztsh.wymiana.exception.InsufficientFundsException;
import eu.ztsh.wymiana.validation.InstanceValidator; import eu.ztsh.wymiana.validation.InstanceValidator;
import eu.ztsh.wymiana.validation.ValidationFailedException; import eu.ztsh.wymiana.validation.ValidationFailedException;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.DisplayName; import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest; import org.junit.jupiter.params.ParameterizedTest;
@ -61,11 +60,12 @@ class CurrencyServiceTest extends RepositoryBasedTest {
@Test @Test
void insufficientFundsTest() { void insufficientFundsTest() {
assertThatThrownBy(() -> currencyService.exchange(EntityCreator.exchangeRequest() var entity = EntityCreator.exchangeRequest()
.from(PLN_SYMBOL) .from(PLN_SYMBOL)
.to(USD_SYMBOL) .to(USD_SYMBOL)
.toBuy(PLN) .toBuy(PLN)
.build())) .build();
assertThatThrownBy(() -> currencyService.exchange(entity))
.isInstanceOf(InsufficientFundsException.class); .isInstanceOf(InsufficientFundsException.class);
} }
@ -73,32 +73,35 @@ class CurrencyServiceTest extends RepositoryBasedTest {
@ParameterizedTest @ParameterizedTest
@MethodSource @MethodSource
void invalidPeselTest(String pesel) { void invalidPeselTest(String pesel) {
assertThatThrownBy(() -> currencyService.exchange(EntityCreator.exchangeRequest() var entity = EntityCreator.exchangeRequest()
.pesel(pesel) .pesel(pesel)
.from(PLN_SYMBOL) .from(PLN_SYMBOL)
.to(USD_SYMBOL) .to(USD_SYMBOL)
.toSell(USD_SELL) .toSell(USD_SELL)
.build())) .build();
assertThatThrownBy(() -> currencyService.exchange(entity))
.isInstanceOf(ValidationFailedException.class); .isInstanceOf(ValidationFailedException.class);
} }
@Test @Test
@DisplayName("Empty 'from' value") @DisplayName("Empty 'from' value")
void emptyFromTest() { void emptyFromTest() {
assertThatThrownBy(() -> currencyService.exchange(EntityCreator.exchangeRequest() var entity = EntityCreator.exchangeRequest()
.to(USD_SYMBOL) .to(USD_SYMBOL)
.toSell(USD_SELL) .toSell(USD_SELL)
.build())) .build();
assertThatThrownBy(() -> currencyService.exchange(entity))
.isInstanceOf(ValidationFailedException.class); .isInstanceOf(ValidationFailedException.class);
} }
@Test @Test
@DisplayName("Empty 'to' value") @DisplayName("Empty 'to' value")
void emptyToTest() { void emptyToTest() {
assertThatThrownBy(() -> currencyService.exchange(EntityCreator.exchangeRequest() var entity = EntityCreator.exchangeRequest()
.from(PLN_SYMBOL) .from(PLN_SYMBOL)
.toSell(USD_SELL) .toSell(USD_SELL)
.build())) .build();
assertThatThrownBy(() -> currencyService.exchange(entity))
.isInstanceOf(ValidationFailedException.class); .isInstanceOf(ValidationFailedException.class);
} }

10
src/test/java/eu/ztsh/wymiana/validation/ValidExchangeRequestValidatorTest.java
View file

@ -2,15 +2,13 @@ package eu.ztsh.wymiana.validation;
import eu.ztsh.wymiana.EntityCreator; import eu.ztsh.wymiana.EntityCreator;
import eu.ztsh.wymiana.web.model.CurrencyExchangeRequest; import eu.ztsh.wymiana.web.model.CurrencyExchangeRequest;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.DisplayName; import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.MethodSource;
import java.util.stream.Stream; import static eu.ztsh.wymiana.EntityCreator.Constants.PLN_SYMBOL;
import static eu.ztsh.wymiana.EntityCreator.Constants.USD_BUY;
import static eu.ztsh.wymiana.EntityCreator.Constants.*; import static eu.ztsh.wymiana.EntityCreator.Constants.USD_SELL;
import static eu.ztsh.wymiana.EntityCreator.Constants.USD_SYMBOL;
class ValidExchangeRequestValidatorTest extends ValidatorTest<ValidExchangeRequestValidator, CurrencyExchangeRequest> { class ValidExchangeRequestValidatorTest extends ValidatorTest<ValidExchangeRequestValidator, CurrencyExchangeRequest> {