stawros/http-mock-server
1
0
Fork 0
Code Releases Packages Activity

Do not allow for System exit

Browse source 
Change-Id: I268b12dfab2e6021ad057a4dc9716a01efbe375d
This commit is contained in:
Dominik Adam Przybysz 2015-09-19 20:14:09 +02:00
parent f03618873e
commit 5545b67ebd
2 changed files with 31 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

27
mockserver-tests/src/test/groovy/pl/touk/mockserver/tests/MockServerIntegrationTest.groovy
View file

@ -839,4 +839,31 @@ class MockServerIntegrationTest extends Specification {
false | 1
true | 0
}
@Unroll
def "should reject mock when it has System.exit in closure"() {
when:
remoteMockServer.addMock(new AddMockRequestData(
name: 'testRest',
path: 'testEndpoint',
port: 9999,
predicate: predicate,
response: '''{req -> "<goodResponseRest-${req.xml.name()}/>"}''',
soap: false
))
then:
thrown(InvalidMockDefinition)
expect:
remoteMockServer.listMocks() == []
where:
predicate << [
'''{req -> System.exit(-1); req.xml.name() == 'request'}''',
'''{req -> System .exit(-1); req.xml.name() == 'request'}''',
'''{req -> System
.exit(-1); req.xml.name() == 'request'}''',
'''{req -> System. exit(-1); req.xml.name() == 'request'}''',
'''{req -> System.exit (-1); req.xml.name() == 'request'}'''
]
}
}

5
mockserver/src/main/groovy/pl/touk/mockserver/server/Mock.groovy
View file

@ -18,7 +18,7 @@ class Mock implements Comparable<Mock> {
String responseHeadersClosureText = '{ _ -> [:] }'
Closure predicate = toClosure(predicateClosureText)
Closure response = toClosure(responseClosureText)
Closure responseHeaders =toClosure(responseHeadersClosureText)
Closure responseHeaders = toClosure(responseHeadersClosureText)
boolean soap = false
int statusCode = 200
String method = 'POST'
@ -64,6 +64,9 @@ class Mock implements Comparable<Mock> {
}
private Closure toClosure(String predicate) {
if (predicate ==~ /(?m).*System\s*\.\s*exit\s*\(.*/) {
throw new RuntimeException('System.exit is forbidden')
}
GroovyShell sh = new GroovyShell(this.class.classLoader);
return sh.evaluate(predicate) as Closure
}